Giving Constructive Feedback in One-on-One Meetings

What you'll learn

Preparing for the Meeting

Structuring Feedback

Sharing Details Effectively

Following Up After the Meeting

Engineering managers play a pivotal role in guiding their teams toward excellence. Providing constructive feedback during one-on-one meetings is a key skill that can enhance performance, boost morale, and foster professional growth among software engineers. This article offers practical advice on preparing for these sessions, structuring feedback for clarity, delivering it in a supportive manner, and ensuring effective follow-up to drive real change.

Preparing for the Meeting

Effective feedback begins long before the meeting starts. As an engineering manager, thorough preparation sets the stage for a productive conversation. Begin by reviewing the engineer's recent work, such as code commits, project contributions, and any metrics from tools like code review platforms or performance dashboards. Identify specific examples of strengths and areas for improvement—focus on observable behaviors rather than vague impressions. For instance, note how an engineer optimized a database query to reduce latency by 30%, or how they could improve by incorporating more unit tests in their pull requests.

Gather input from multiple sources to ensure a balanced view. This might include feedback from peers during code reviews or insights from cross-functional team members on collaboration skills. Organize your notes into categories: positive reinforcements, suggestions for growth, and any patterns observed over time. Anticipate potential reactions by considering the engineer's personality—some may appreciate directness, while others benefit from a gentler approach. Set clear objectives for the meeting, such as aligning on skill development goals or addressing a recurring issue like deadline misses. Finally, schedule the meeting at a time when both parties are likely to be focused, and allocate at least 30-45 minutes to allow for dialogue without rushing.

Preparation also involves self-reflection. Ask yourself: Is this feedback timely and relevant? Does it tie back to team or company goals, like improving code maintainability or enhancing agile practices? By investing time upfront, you demonstrate respect for the engineer's development, turning the one-on-one into a collaborative opportunity rather than a critique session.

Structuring the Feedback

A well-structured feedback framework ensures your message is clear, actionable, and balanced, preventing misunderstandings that could demotivate talented engineers. Adopt a model like the SBI (Situation-Behavior-Impact) approach: Describe the specific situation, detail the observed behavior, and explain its impact on the team or project.

Start with positives to build rapport—highlight what the engineer is doing well, such as their innovative use of microservices architecture in a recent feature. Then, transition to areas for improvement, framing them as opportunities rather than flaws. For example, instead of saying "Your code is messy," structure it as: "In the last sprint (situation), I noticed that variable names were inconsistent (behavior), which made it harder for the team to review and maintain the code (impact). Let's explore ways to standardize naming conventions."

Keep feedback specific and limited—aim for 2-3 key points per meeting to avoid overwhelming the recipient. Prioritize items that align with the engineer's career goals, like advancing from mid-level to senior by focusing on system design principles. Include actionable steps, such as recommending pair programming sessions or resources for learning design patterns. End on a forward-looking note, discussing how addressing these areas will contribute to their growth and the team's success.

Sharing the Feedback Effectively

Delivery is as crucial as content; poor sharing can undermine even the best-prepared feedback. Create a safe environment by starting with an invitation for the engineer to share their self-assessment first—this encourages ownership and reveals any blind spots. Use empathetic language to convey care, such as "I want to support your growth because I see great potential in you."

Be direct yet kind: Avoid sugarcoating, as it dilutes the message, but steer clear of harsh tones that could trigger defensiveness. For software-specific feedback, use concrete examples like code snippets to illustrate points, saying, "Here's how refactoring this loop could improve readability and performance." Listen actively—pause after sharing feedback to allow questions or responses, and validate their feelings with phrases like "I understand this might feel challenging."

Encourage two-way dialogue by asking open-ended questions: "How do you feel about this?" or "What support do you need to implement changes?" This transforms the meeting into a partnership, empowering the engineer to co-create solutions. If emotions run high, remain calm and refocus on facts and growth. In remote settings, use video calls to read non-verbal cues, ensuring the human element isn't lost.

Following Up After the Meeting

Feedback's true value emerges through consistent follow-up, turning words into actionable progress. Immediately after the meeting, document key points, agreed-upon actions, and timelines in a shared note or tool like a project management app. Send a summary email recapping the discussion, such as: "We agreed you'd experiment with TDD in the next sprint, and I'll check in during our next one-on-one."

Schedule check-ins—perhaps a quick mid-week touch-base—to monitor progress without micromanaging. Celebrate wins, like when an engineer successfully applies feedback to reduce bugs in production. If goals aren't met, revisit them collaboratively, adjusting plans as needed. Track long-term patterns in subsequent meetings to reinforce positive changes and address persistent issues.

Follow-up also builds trust, showing that you invest in their success beyond the meeting. Over time, this creates a culture of continuous improvement, where engineers proactively seek feedback.

Summary

This article has equipped engineering managers with strategies to deliver constructive feedback in one-on-one meetings, covering preparation through review and example gathering, structuring via models like SBI, effective sharing with empathy and dialogue, and diligent follow-up for sustained growth. Mastering these elements fosters a supportive environment that elevates software engineers' performance and team dynamics.